Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reimplementation #130

Merged
merged 3 commits into from
Aug 15, 2020
Merged

feat: reimplementation #130

merged 3 commits into from
Aug 15, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jul 26, 2020

Inspired by hexo-filter-mathjax.

@curbengh
Copy link
Contributor Author

curbengh commented Jul 26, 2020

@yoshinorin gh actions not enabled?


fixed

@curbengh curbengh force-pushed the overhaul branch 5 times, most recently from 895d5b6 to c0de6bf Compare July 27, 2020 17:01
@curbengh curbengh changed the title complete overhaul feat: reimplementation Jul 27, 2020
@curbengh curbengh force-pushed the overhaul branch 2 times, most recently from 7d35cbb to d6be3a1 Compare July 27, 2020 17:08
@curbengh curbengh requested a review from stevenjoezhang July 27, 2020 17:13
- Support arguments in tag plugins as renderer options
- Support front-matter as renderer options
- Support _config.yml as renderer options
- Requires Node 10.13+, drop Node 8
- chore(deps): update katex from 0.6.0 to 0.12.0
- chore(deps): add mathjax
- chore(deps): update hexo-util from 1.0.0 to 2.2.0
- chore(dev-deps): update eslint from 6.1.0 to 7.5.0
- chore(dev-deps): update eslint-config-hexo from 3.0.0 to 4.1.0
- chore(deps): update mocha from 6.1.2 to 8.0.1
- chore(deps): remove html-entities
- chore(dev-deps): remove chai-as-promised, cpx, hexo-fs, npm-run-all & rimraf
- ci(travis): add Windows
- ci: add GitHub Actions
@yoshinorin
Copy link
Member

@yoshinorin gh actions not enabled?

No. It is enabled 🤔

https://github.com/hexojs/hexo-math/settings/actions

ga

@curbengh
Copy link
Contributor Author

curbengh commented Aug 1, 2020

@stevenjoezhang since you have experience with mathjax, can you help test this? Thank you.

@stevenjoezhang
Copy link
Member

@curbengh It's my pleasure.
There is currently a known issue that mathjax will remove HTML comments on the page, causing <!-- more --> to be invalid. Relevant PR mathjax/MathJax-src#523

@curbengh
Copy link
Contributor Author

curbengh commented Aug 1, 2020

There is currently a known issue that mathjax will remove HTML comments on the page

shouldn't affect tag plugin I think?

@curbengh curbengh force-pushed the overhaul branch 3 times, most recently from 267ab24 to d9f7dd8 Compare August 8, 2020 06:20
options:
throwOnError: false
mathjax:
css: 'https://cdn.jsdelivr.net/gh/hexojs/hexo-math/dist/style.css'
Copy link
Contributor Author

@curbengh curbengh Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curbengh curbengh merged commit 3e5522e into hexojs:master Aug 15, 2020
@curbengh curbengh deleted the overhaul branch August 15, 2020 09:33
curbengh added a commit to curbengh/hexo-math that referenced this pull request Aug 21, 2020
curbengh added a commit to curbengh/hexo-math that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants