Bring up a brand new hexo-filter-nofollow #1
Conversation
SukkaW
requested review from
curbengh,
lzjqsdd,
yoshinorin and
segayuu
and removed request for
lzjqsdd
| @@ -0,0 +1,38 @@ | |||
| { | |||
| "name": "hexo-filter-nofollow", | |||
| "version": "2.0.0", | |||
There was a problem hiding this comment.
https://www.npmjs.com/package/hexo-filter-nofollow/v/1.0.1 is already published (which doesn't include this PR).
| @@ -0,0 +1 @@ | |||
| package-lock=false | |||
There was a problem hiding this comment.
FYI
We discussing lock file in hexojs/hexo#3370 (It hasn't reached a conclusion yet)
There was a problem hiding this comment.
For hexo-filter-nofollow the lock file is not necessary, since it has no dependencies at all.
| }, | ||
| "scripts": { | ||
| "eslint": "eslint .", | ||
| "test": "echo \"Error: no test specified\" && exit 1" |
There was a problem hiding this comment.
IMHO you can choose anything test framework you want when you write a unit test code.
There was a problem hiding this comment.
Or even a dummy test like https://github.com/hexojs/hexo-uglify, but it can be done in a separate PR.
There was a problem hiding this comment.
A unit test might be added later in another PR.
|
@SukkaW Do you have anything else to add? Feel free to merge this and publish. |
|
https://www.npmjs.com/package/hexo-filter-nofollow/v/2.0.0 |
fieldoption