Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix time of keymap definition #33

Closed
wants to merge 2 commits into from
Closed

Fix time of keymap definition #33

wants to merge 2 commits into from

Conversation

CyberShadow
Copy link
Contributor

@CyberShadow CyberShadow commented Oct 11, 2018 •
edited
Loading

This fixes using use-package's :bind to customize mediawiki-mode-map.

@CyberShadow
Clear executable flags off non-executable files
6d2ee96
@CyberShadow
Fix time of keymap definition
6c87304 
Keymaps should be defined once when the package is loaded, not every
time the mode is enabled. The correct way allows customizing the
keymap using facilities such as use-package's :bind definitions,
whereas the previous way clobbered any user customizations in the
keymap every time mediawiki-mode was enabled.
@hexmode hexmode force-pushed the master branch 2 times, most recently from b5dcd15 to 5178a1a Compare July 6, 2020 04:34
@hexmode
Copy link
Owner

hexmode commented Jul 7, 2020

This might address #36

@hexmode
Copy link
Owner

hexmode commented Jul 10, 2020 •
edited
Loading

Squashed and merged separately.

@hexmode hexmode closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberShadow @hexmode