Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use new client.Action.WaitFor #636

Closed
wants to merge 5 commits into from
Closed

refactor: use new client.Action.WaitFor #636

wants to merge 5 commits into from

Conversation

jooola
Copy link
Member

@jooola jooola commented Apr 30, 2024

This use the new client.Action.WaitFor API for waiting actions.

@jooola jooola force-pushed the use-action-waiter branch from 7114f47 to 2216b6a Compare April 30, 2024 15:12
@jooola jooola force-pushed the use-action-waiter branch from 2216b6a to baa7b25 Compare April 30, 2024 15:17
apricote
apricote approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. The CI failure seems to affect every PR open right now.

@apricote apricote mentioned this pull request May 3, 2024
Merged
@jooola
Copy link
Member Author

jooola commented May 6, 2024

Part of #628

@jooola jooola closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jooola @apricote