fix: revert invalid topology changes #333 #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert all changes we made to our reported topology for nodes and volumes. Because we report two segments on the `NodeGetInfo` call, but only one of them on `CreateVolume` we are not compliant with the CSI spec. This did not matter for Kubernetes, because the scheduler still worked, but it breaks Nomad. As we are not compliant with the CSI spec, we decided to revert these changes, even though it will require user intervention to fix volumes created in the meantime. For details see issue #333.
6 tasks
samcday
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert all changes we made to our reported topology for nodes and volumes.
Because we report two segments on the
NodeGetInfocall, but only one of them onCreateVolumewe are not compliant with the CSI spec. This did not matter for Kubernetes, because the scheduler still worked, but it breaks Nomad.As we are not compliant with the CSI spec, we decided to revert these changes, even though it will require user intervention to fix volumes created in the meantime.
For details see issue #333.
This is intended for v2.1.0