This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Properly inform the user if he has not enabled the GitHub integration when diffing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for his account and tries to do a diff.
|
Oh wow, we really dropped the ball on this one. @krummi would you mind rebasing? |
|
No problem ;) working on rebasing! Will hopefully manage to finish it tomorrow. |
|
I would really love to see this get merged, please |
|
@krummi nudge nudge. :) |
|
Oh sorry guys, I'm terribly busy with my studies. I will take a look at this as soon as I can though. :) |
|
I'll try to pick up the rebase when I've got a slow moment. Will probably open up another PR for this as I can't push to your branch @krummi. Is that alright with you? |
|
Absolutely @gudmundur. Sorry I haven't found the time to fix this! It should be simple though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better error messaging when someone does
heroku pipelines:diffand has not enabled the GitHub integration for his Heroku account.Before:
After:
