-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(detach): update arg description & error messaging #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated the order of precedence for the environment variable in the addonServiceSlug getter because we don't update the addonServiceSlug value before evaluating it's value. This is problematic for managing different environments like heroku-inference vs. inference-dev for the HEROKU_INFERENCE_ADDON environment variable.
5ab5c07
to
54c0d8d
Compare
54c0d8d
to
fb3e8af
Compare
leoncalermo
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
justinwilaby
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work Item
This PR updates the
model resource
argument description to only specify an alias. In addition, this PR also updates the error messaging when an invalid alias is entered. This PR also fixes a regression from a previous refactor that used the incorrect model ID.Testing
NOTE: Until the addon service name is updated to
heroku-inference
instead ofinference
, make sure you export the correct environment variable viaexport HEROKU_INFERENCE_ADDON="inference-dev"
yarn && yarn build
it upheroku apps:create test-cli-ai-plugin-app
heroku ai:models:create claude-3-5-haiku --as MY_EXAMPLE_MODEL --app test-cli-ai-plugin-app
heroku addons -a test-cli-ai-plugin-app
. The name will be in parenthesis with the following formatinference-dev-<adjective>-XXXXX
heroku addons:attach <inference-dev-<adjective>-XXXXX> -a test-cli-ai-plugin-app --as my_example_model_again
alias
via./bin/run ai:models:detach <inference-dev-<adjective>-XXXXX> -a test-cli-ai-plugin-app
./bin/run ai:models:detach my_example_model_again -a test-cli-ai-plugin-app
Test clean up
heroku ai:models:destroy MY_EXAMPLE_MODEL -a test-cli-ai-plugin-app
heroku apps:destroy -a test-cli-ai-plugin-app