Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
ai:models:attach
command with tests according to the design outlined in the UX design doc.How to test
Prepare your environment for testing
yarn && yarn build
.HEROKU_INFERENCE_ADDON
to the production canary add-on viaexport HEROKU_INFERENCE_ADDON="inference-staging"
Actual testing
./bin/run ai:models:attach --help
heroku apps:create test-cli-plugin-ai
./bin/run ai:models:create claude-3-haiku -a test-cli-plugin-ai --as HAIKU_ORIGINAL
to create a provisioned model.heroku addons -a test-cli-plugin-ai
and grab the add-on name for the provisioned model../bin/run ai:models:attach <addon-name> -a test-cli-plugin-ai --as HAIKU_AGAIN
and confirm that the command succeeds, creating another attachment to the model resource. Useheroku config -a test-cli-plugin-ai
to confirm that config varsHAIKU_AGAIN_...
share the exact same values asHAIKU_ORIGINAL_...
../bin/run ai:models:create claude-3-haiku -a test-cli-plugin-ai --as HAIKU_AGAIN
to create a new provisioned model reusing the attachment name. A confirmation step will be required to allow overwriting the config vars. Confirm by entering the app name and confirm that nowHAIKU_ORIGINAL_KEY
andHAIKU_AGAIN_KEY
have different values.heroku apps:destroy -a test-cli-plugin-ai
SOC2 Compliance
GUS Work Item