-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-ai): Add 'ai:models:info' command #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments. It seems that copies don't align with the latest approved ones, maybe you were following the API design doc, but we should be following this one instead: https://docs.google.com/document/d/1Fo4M5RqbHQILYYmHKty13QGS8hqK1A69swGczJiuDyg/edit#heading=h.2saci73qrjpz.
Still need to update types naming
88feba9
to
bc40f47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I tested and it works as a charm. I suggest adding a header when multiple model resources are returned to differentiate one from another, but that's all. I'm approving.
Description
This PR implements the
ai:models:info
command with tests according to the design outlined in the UX design doc.How to test
Prepare your environment for testing
yarn && yarn build
.HEROKU_INFERENCE_HOST
to staging viaexport HEROKU_INFERENCE_HOST=staging.inference.herokai.com
Actual testing
./bin/run ai:models:info --help
heroku apps:create test-cli-plugin-ai
heroku addons:create inference-staging:claude-3-sonnet -a test-cli-plugin-ai
./bin/run ai:models:info inference-staging:claude-3-sonnet -a test-cli-plugin-ai
The resulting output should display as follows:./bin/run ai:models:info -a test-cli-plugin-ai
The resulting output should display as follows:Test clean up
heroku apps:destroy -a test-cli-plugin-ai
(x2
as you will have 2 model resource attachments)HEROKU_INFERENCE_HOST
viaunset HEROKU_INFERENCE_HOST
SOC2 Compliance
GUS Work Item