Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 support #376

Closed
sylvaindeloux opened this issue Nov 30, 2019 · 23 comments · Fixed by #385
Closed

PHP 7.4 support #376

sylvaindeloux opened this issue Nov 30, 2019 · 23 comments · Fixed by #385

Comments

@sylvaindeloux
Copy link

sylvaindeloux commented Nov 30, 2019

When adding "php": "^7.4" to composer.json, the build fails (using web: vendor/bin/heroku-php-nginx):

composer.json/composer.lock requires php ^7.4 -> no matching package found.
@dzuelke
Copy link
Contributor

dzuelke commented Dec 2, 2019

Yes. It's not rolled out on Heroku yet. It's the Black Friday and Cyber Monday weekend, so we're obviously not making any changes, in particular not such a major one that could incur app downtime for customers with untested apps and open version requirement ranges.

Second or third week of December is currently the plan. Like always, the changelog will list all updates as they happen.

@robinwo
Copy link

robinwo commented Dec 23, 2019

Any update on this guys? Have a release pending which depends on PHP 7.4 support. 😅

@dzuelke
Copy link
Contributor

dzuelke commented Dec 23, 2019

We've had to move it to January, sorry. There's just too little time with the holidays and everything, we have a bunch of production change freezes in place around this time.

@asgrim
Copy link

asgrim commented Dec 23, 2019

we have a bunch of production change freezes in place around this time.

Makes sense, it is winter after all.... 😅

@romainnorberg
Copy link

please 😄

@imayolas
Copy link

imayolas commented Jan 9, 2020

Hello, what is your current ETA for releasing the support for php 7.4? thanks.

@Monamoxie
Copy link

We need support for PHP 7.4. This delay is getting too far. Kindly treat as urgent

@morrislaptop
Copy link

/me looks at platform.sh

@dimskor
Copy link

dimskor commented Jan 15, 2020

Still not added?

@Segfaultd
Copy link

Segfaultd commented Jan 15, 2020

Dear Heroku devs @dzuelke , we definitely need it, please add it 🙏

EDIT: Finally found a solution, I migrated my backend to clever-cloud.com that support php 7.4 Took me 5mn to migrate from heroku to there!

@sylvaindeloux
Copy link
Author

Any news about this update?
I have a deploy waiting since… end of november… 😅

@sylvaindeloux
Copy link
Author

@dzuelke Is this more complex than expected?

@AdaptCharm
Copy link

AdaptCharm commented Jan 28, 2020

@dzuelke Any update on this one? I just tried to upgrade from PHP 7.3 to PHP 7.4, received the same error message above.

I need PHP 7.4 so that I can implement preloading to my app.
EDIT: Might actually consider switching to Clever-Cloud as they support PHP 7.4.

@sylvaindeloux
Copy link
Author

PHP 7.4.2 has been released, and we're still waiting 😂

https://www.php.net/archive/2020.php#2020-01-23-1

@pierre-le
Copy link

+1 on this one.
And guys at Heroku, we do understand you may have other priorities to handle, but a quick update would be greatly appreciated :)

@Raerten
Copy link

Raerten commented Jan 30, 2020

7.4 branch brought great language features and many composer packages require that version.
so long update is not user friendly.
can you give us a real time frame? @dzuelke

@ghost
Copy link

ghost commented Jan 31, 2020

Yes. It's not rolled out on Heroku yet. It's the Black Friday and Cyber Monday weekend, so we're obviously not making any changes, in particular not such a major one that could incur app downtime for customers with untested apps and open version requirement ranges.

Second or third week of December is currently the plan. Like always, the changelog will list all updates as they happen.

For me it's an inadmissible answer. As a PaaS, Heroku should always provide the latest version of packages/utilities, as soon as possible (even beta/RC in my opinion). This is the responsability of developers to ensure the good range of the version they need in the project manifest. Open range in manifest is irresponsible and you're not reponsable of this. Your responsability is provide the latest tools despite unconscious developers.

@sylvaindeloux
Copy link
Author

According to Heroku support:

Will will be offering support for PHP 7.4 sometime next month. Please check our changelog for any updates.

@dzuelke dzuelke mentioned this issue Feb 6, 2020
@dzuelke
Copy link
Contributor

dzuelke commented Feb 6, 2020

Soon, fans, soon. #385 is almost ready for roll-out.

Once that's done, I'll also take a few minutes and respond to a few of the comments on this ticket.

@AdaptCharm
Copy link

Soon, fans, soon. #385 is almost ready for roll-out.

Once that's done, I'll also take a few minutes and respond to a few of the comments on this ticket.

Can you explain the delay and why it has taken so long?

Ocramius added a commit to Roave/SecurityAdvisoriesBuilder that referenced this issue Feb 10, 2020
@boboldehampsink
Copy link

Is there anywhere we can track the progress of supporting regex in mbstring? Can't use PHP 7.4 without that

@dzuelke
Copy link
Contributor

dzuelke commented Feb 11, 2020

It'll be back with PHP 7.4.3, @boboldehampsink.

@dzuelke
Copy link
Contributor

dzuelke commented Mar 2, 2020

Just to close the loop here regarding mbstring, 7.4.3 is built against libonig, so regexes are now supported / cc @boboldehampsink @fobin @celorodovalho @obrassard: https://devcenter.heroku.com/changelog-items/1743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.