Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set package.json scripts.start as a default process #214

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Mar 23, 2022

In #184, we updated the buildpack api version for heroku/npm to 0.6. This had the unintended side effect of the web process no longer being flagged as a default process. In earlier buildpack API versions, overwriting a default process with an undefined default would result in a process flagged as default. Newer buildpack API versions will prefer the default setting of the overwriting process.

This PR ensures the web process affiliated with package.json's scripts.start is flagged as a default process, for both yarn and npm.

Fixes #211

W-10888625

@joshwlewis joshwlewis requested a review from a team as a code owner March 23, 2022 15:32
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I presume you'll add an integration test for this when you write the libcnb-tests for this repo, once the remaining conversions are performed? :-))

@joshwlewis
Copy link
Member Author

I presume you'll add an integration test for this when you write the libcnb-tests for this repo

Yes, that's the plan. The npm and yarn buildpacks will be completely replaced (including tests), hopefully soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js app's "start" script not used anymore
2 participants