Fix conversion of platforms for 'Internal' annotation #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of internal attribute platforms can be specified
inside the annotation. However, when quotation marks are not
present for each listed platform, then the behavior of converter
is invalid.
This change adds omitted files for smoke tests.
Please note, that the visibility for mentioned types is as follows:
- JavaInternalClassRev -- shall be internal only for Java, but
it is internal also in Swift and Dart.
- SwiftInternalClassRev -- shall be internal only for Swift, but
it is internal also in Java and Dart.
- DartInternalClassRev -- shall be internal only for Dart, but
it is internal also in Swift and Java.
In next patches the logic will be fixed. The mentioned files will
be used to show that the behavior has been adjusted.
Signed-off-by: Patryk Wrobel <[email protected]>
The conversion of platforms for 'Internal' annotation was invalid when they were specified without quotation marks. In such a case the converter set internal visibility for all platforms. This change adjusts the converter as well as the output of smoke tests to show that the behavior is correct now. Signed-off-by: Patryk Wrobel <[email protected]>
|
For the first commit, which shows the invalid behavior please see the following input: Even though platforms are specified, the behavior without fix was incorrect -- the classes were internal for all platforms. With the fix they are internal only for the specified platforms. |
Hsilgos
approved these changes
Nov 5, 2024
pwrobeldev
deleted the
pwrobeldev/fix-parsing-of-platforms-passed-to-internal-annotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion of platforms for 'Internal' annotation was invalid
when they were specified without quotation marks. In such a case
the converter set internal visibility for all platforms.
This change adjusts the converter as well as the output of smoke
tests to show that the behavior is correct now.