Avoids passing of useless parameter #1585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert_from_jni functions use last parameter only for function overloading because
normally those functions are different by the return parameter. In all places where
function convert_from_jni is used the last parameter is nullptr which is C-casted to the desired type.
As godbolt demonstrates modern clang and gcc have to pass this parameter without any optimisation.
This can be improved if this parameter is empty object (i.e. an object of a class without any fields) and
it's passed by value. As godbolt shows in this case modern cland and gcc generate code as if there is no any parameter at all.