Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination is not respecting the total value #25

Closed
jfedick opened this issue Oct 31, 2019 · 1 comment
Closed

Pagination is not respecting the total value #25

jfedick opened this issue Oct 31, 2019 · 1 comment

Comments

@jfedick
Copy link

jfedick commented Oct 31, 2019

ra-jsonapi-client/src/index.js

Line 141 in dd65b86

total = response.data.data.length;

Shouldn't this be total = response.data.meta[settings.total]?
@henvo henvo closed this as completed in 56fcbe5 Nov 1, 2019
henvo pushed a commit that referenced this issue Nov 1, 2019
Fix total length bug
919f48e 
Fixes #25 thanks to @jfedik
@henvo
Copy link
Owner

henvo commented Nov 1, 2019

Whoops! Good catch... fixed in v0.6.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfedick @henvo