Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/horovod] Major version bump: Fix chart not being upgradable. #8596

Merged
merged 1 commit into from
Oct 21, 2018
Merged

[stable/horovod] Major version bump: Fix chart not being upgradable. #8596

merged 1 commit into from
Oct 21, 2018

Conversation

desaintmartin
Copy link
Collaborator

See #7680.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped

cc @cheyang

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 19, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 19, 2018
@cheyang
Copy link
Collaborator

cheyang commented Oct 20, 2018

/lgtm
/approve

Thanks for contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, desaintmartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2018
@cheyang
Copy link
Collaborator

cheyang commented Oct 21, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit c5b9357 into helm:master Oct 21, 2018
@k8s-ci-robot
Copy link
Contributor

@desaintmartin: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 9788102 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

darioblanco pushed a commit to minddocdev/charts that referenced this pull request Oct 22, 2018
emas80 pushed a commit to faceit/charts that referenced this pull request Oct 24, 2018
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@desaintmartin desaintmartin deleted the horovod branch November 21, 2019 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants