[incubator/elasticsearch] Add pod disruption budgets. #2530
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -127,3 +127,23 @@ spec: | |||
| resources: | |||
| requests: | |||
| storage: "{{ .Values.master.storage }}" | |||
| --- | |||
There was a problem hiding this comment.
Please move the inline definition to a file, naming suggestion master-pdb.yaml
| @@ -131,3 +131,23 @@ spec: | |||
| resources: | |||
| requests: | |||
| storage: "{{ .Values.data.storage }}" | |||
| --- | |||
There was a problem hiding this comment.
Inline definition to a file, naming suggestion data-pdb.yaml
incubator/elasticsearch/values.yaml
Outdated
| @@ -38,6 +38,8 @@ master: | |||
| storage: "4Gi" | |||
| # storageClass: "ssd" | |||
| antiAffinity: "soft" | |||
| budget: | |||
| minAvailable: 1 | |||
There was a problem hiding this comment.
Need readme documentation for this value
| apiVersion: policy/v1beta1 | ||
| kind: PodDisruptionBudget | ||
| metadata: | ||
| name: "{{ template "elasticsearch.master.fullname" . }}-master-budget" |
There was a problem hiding this comment.
Should not need the ending suffix, assuming there is no specific reason behind this choice.
| apiVersion: policy/v1beta1 | ||
| kind: PodDisruptionBudget | ||
| metadata: | ||
| name: "{{ template "elasticsearch.master.fullname" . }}-data-budget" |
There was a problem hiding this comment.
same as below, but should be {{ template "elasticsearch.data.fullname" . }}
|
Marking this as stale. Please update within one week. |
|
@unguiculus this is ready for review. |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@jmcarp Readme update still missing. |
|
Marking stale. Please update readme. |
|
Closing as stale. Feel free to reopen if/when you decide to pick this up again. |
So that clusters don't become unavailable during node restarts.
cc @icereval