Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Update postgres to use statefulset? #809

Closed
imranismail opened this issue Mar 17, 2017 · 22 comments
Closed

Update postgres to use statefulset? #809

imranismail opened this issue Mar 17, 2017 · 22 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@imranismail
Copy link

As described in the following blog post: http://blog.kubernetes.io/2017/02/postgresql-clusters-kubernetes-statefulsets.html

@kachkaev
Copy link
Contributor

@jmccormick2001 WDYT on contributing on the official chart following your great blog post?

@jmccormick2001
Copy link

I'd be open to doing that, let me see if I can contribute to this.

@mattfarina
Copy link
Contributor

cc: @swordbeta @databus23

This is a good idea. Some charts like the stable/consul chart are already using statefulsets. If someone is interested in contributing this would be nice to have.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2018
@canhnt
Copy link

canhnt commented Mar 19, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2018
@kfox1111
Copy link
Collaborator

kfox1111 commented Apr 3, 2018

I just noticed this when in my minikube I deleted postgresql and a new instance launched before the old one was deleted. This is potentially a data corrupting bug!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2018
@stale
Copy link

stale bot commented Aug 8, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this as completed Aug 8, 2018
@cliedeman
Copy link
Contributor

/remove-lifecycle stale

@mattfarina mattfarina reopened this Aug 9, 2018
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2018
@gkarthiks
Copy link
Contributor

i can work on this.

@gkarthiks
Copy link
Contributor

seems there is one pending PR from someone on this chart #7589

@gkarthiks
Copy link
Contributor

Is it fine if I create another PR separately ?

@desaintmartin
Copy link
Collaborator

This PR has nothing to do with StatefulSet, so yes, go on!

@desaintmartin
Copy link
Collaborator

desaintmartin commented Sep 14, 2018

Everyone: Just to be clear, would such a change break compatibility with official postgres image? Should this be a new, different chart named for example postgres-ha or crunchy-postgresql, or even crunchy (likewise, we have a chart named patroni)?

@cliedeman
Copy link
Contributor

It would break backwards compatibility but there is not much choice. An alternative chart would duplicate work and cause confusion. And eventually, we would want to replace the original postgres chart with the stateful set version putting us right back at this discussion.

@mattfarina
Copy link
Contributor

The semver on the chart would need to have a major version bump. Ideally, PVCs handling data could be handled gracefully (though this is an untested ideal)

@gkarthiks
Copy link
Contributor

gkarthiks commented Oct 21, 2018

/assign @gkarthiks

@k8s-ci-robot
Copy link
Contributor

@gkarthiks: GitHub didn't allow me to assign the following users: gkarthiks.

Note that only helm members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign gkarthiks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@desaintmartin
Copy link
Collaborator

Beware that #8004 is in the process of being merged.

@gkarthiks
Copy link
Contributor

@desaintmartin I thought no one will pick this issue, since I committed on this sometime back.

Closed the my new PR.

If possible i need a way of assigning the issues to my name. So that no conflicts will be arising. @desaintmartin or @davidkarlsen can you please help me on that?

@stale
Copy link

stale bot commented Nov 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 23, 2018
@stale
Copy link

stale bot commented Dec 7, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this as completed Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.