-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Update postgres to use statefulset? #809
Comments
@jmccormick2001 WDYT on contributing on the official chart following your great blog post? |
I'd be open to doing that, let me see if I can contribute to this. |
cc: @swordbeta @databus23 This is a good idea. Some charts like the stable/consul chart are already using statefulsets. If someone is interested in contributing this would be nice to have. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
I just noticed this when in my minikube I deleted postgresql and a new instance launched before the old one was deleted. This is potentially a data corrupting bug! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This issue is being automatically closed due to inactivity. |
/remove-lifecycle stale |
i can work on this. |
seems there is one pending PR from someone on this chart #7589 |
Is it fine if I create another PR separately ? |
This PR has nothing to do with StatefulSet, so yes, go on! |
Everyone: Just to be clear, would such a change break compatibility with official postgres image? Should this be a new, different chart named for example postgres-ha or crunchy-postgresql, or even crunchy (likewise, we have a chart named patroni)? |
It would break backwards compatibility but there is not much choice. An alternative chart would duplicate work and cause confusion. And eventually, we would want to replace the original postgres chart with the stateful set version putting us right back at this discussion. |
The semver on the chart would need to have a major version bump. Ideally, PVCs handling data could be handled gracefully (though this is an untested ideal) |
/assign @gkarthiks |
@gkarthiks: GitHub didn't allow me to assign the following users: gkarthiks. Note that only helm members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Beware that #8004 is in the process of being merged. |
@desaintmartin I thought no one will pick this issue, since I committed on this sometime back. Closed the my new PR. If possible i need a way of assigning the issues to my name. So that no conflicts will be arising. @desaintmartin or @davidkarlsen can you please help me on that? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
As described in the following blog post: http://blog.kubernetes.io/2017/02/postgresql-clusters-kubernetes-statefulsets.html
The text was updated successfully, but these errors were encountered: