Adding timer feature #93
Conversation
|
@SENTHILnew - thanks a lot for the PR - are you able to fix this build/lint error - https://github.com/hellomuthu23/planning-poker/actions/runs/7785090685/job/21239197826?pr=93#step:3:48 |
|
Updated the PR, @hellomuthu23 can you approve the rebuild |
Thanks, its passing now. the deploy to firebase failure can be ignored as the workflow can't access service account |
| <Typography variant='subtitle1' className='GameControllerGameStatus'> | ||
| {game.gameStatus} | ||
| </Typography> | ||
| {isTimerEnabled ? ( |
There was a problem hiding this comment.
It will be good to show the timer values to all users in the session too, but this requires changes in the data model. Probably could add as added feature in another PR.
| onTimerEnd: () => void; | ||
| } | ||
|
|
||
| export const TimerProgress: React.FC<TimerProgressProps> = ({ |
There was a problem hiding this comment.
Can you add a unit test for this component please?
| import TimerIcon from '@material-ui/icons/Timer'; | ||
| import './Timer.css'; | ||
|
|
||
| export const TimerController: React.FC<{ |
There was a problem hiding this comment.
Can you add unit test for this component please?
|
while this is beneficial, other planning poker apps support the timer to be used independently to keep discussion of the story on track. Not so much to have a countdown timer to reveal the cards. Would be beneficial in this scenario as well as add minutes not just seconds. |
📝 Description
This pull request adds a timer feature.
The timer can be enabled or disabled by the moderator. The timer automatically starts on clicking restart. The timer can be disabled anytime. Once the set time is over (only supported time seconds for now) will automatically reveal the voting
🛠️ Changes made
Added new components for showing timer progress and timer toggle button.
Modified gameController component to accommodate the timer toggle and timer progress controls.
🧪 Testing
Added unit tests to ensure the proper toggling of timer control.
Added unit tests for timer end reveal feature.
📸 Screenshots