tests: on_target: add ppk test #474

DematteisGiacomo · 2024-11-18T15:21:03Z

Add ppk test and update nightly badge accordingly. Also, add html interactive power plot, hosted on github pages.

DematteisGiacomo · 2024-11-19T08:19:53Z

see the badge here: https://github.com/hello-nrfcloud/firmware/tree/ppk_test

jorgenmk · 2024-11-19T08:25:02Z

.github/workflows/on_target.yml

+          fi
+
+          # Configure Git to trust the current working directory
+          git config --global --add safe.directory /__w/firmware/firmware


Suggest: git config --global --add safe.directory `pwd`

jorgenmk · 2024-11-19T08:30:16Z

.github/workflows/on_target.yml

+          CSV_FILE=tests/on_target/power_measurements.csv
+
+          # Check if the badge file exists at the specified location
+          if [ -f $BADGE_FILE ]; then


You can use if [ ! -f $BADGE_FILE ];, we don't need to log every time an expected file was found :)

jorgenmk · 2024-11-19T08:35:50Z

tests/on_target/tests/conftest.py

@@ -102,7 +102,7 @@ def t91x_traces(t91x_board):
 def hex_file():
    # Search for the firmware hex file in the artifacts folder
    artifacts_dir = "artifacts"
-    hex_pattern = r"hello\.nrfcloud\.com-[a-f0-9]+-thingy91x-nrf91\.hex"
+    hex_pattern = r"hello\.nrfcloud\.com-[a-z.0-9]+-thingy91x-nrf91\.hex"


Not sure if the dot should be there? r"hello\.nrfcloud\.com-[a-z0-9]+-thingy91x-nrf91\.hex"
Perhaps just change to .* Or maybe you want [0-9a-z\.] for literal dot. (Needs escape)

added the dot to match release files hello.nrfcloud.com-v2.0.1-thingy91x-nrf91.hex
I'll change to [0-9a-z\.]

jorgenmk · 2024-11-19T08:58:58Z

tests/on_target/tests/test_power.py

+
+
+@pytest.fixture(scope="module")
+def ppk2():


I think this should be named thingy91x_ppk2

jorgenmk · 2024-11-19T09:00:07Z

tests/on_target/tests/test_power.py

+    ppk2_dev.use_ampere_meter()  # set ampere meter mode
+    ppk2_dev.toggle_DUT_power("ON")  # enable DUT power
+
+    time.sleep(10)


What are we waiting for here? DUT uart should be available all the time? PPK only cuts power to the nrf91, not the nrf53?

I dont get uart if dut is not powered ON. That is also why I used a single fixture. Otherwise I could have also split ppk2 and uart into independent fixtures.
And I added the sleep to give uart time to show up, maybe can be removed

jorgenmk · 2024-11-19T09:03:37Z

tests/on_target/tests/test_power.py

+SEGGER = os.getenv('SEGGER')
+UART_ID = os.getenv('UART_ID', SEGGER)
+
+def get_uarts():


I think we can import this one from conftest.py instead of redefining?

actually I am also both redefining get_uarts(), will import only

dilner · 2024-11-19T09:38:39Z

.github/workflows/on_target.yml

+        working-directory: thingy91x-oob
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |


Consider moving this to a seperate bash script since it's quite much commands.

dilner · 2024-11-19T09:46:51Z

tests/on_target/tests/test_power.py

+CSV_FILE = "power_measurements.csv"
+HMTL_PLOT_FILE = "power_measurements_plot.html"
+
+SEGGER = os.getenv('SEGGER')


These also are obtained in conftest.py

dilner · 2024-11-19T09:49:24Z

tests/on_target/tests/test_power.py

+    logger.info(f"Minimum average current measured: {average}uA")
+    if average < 0:
+        pytest.fail(f"current cant be negative, current average: {average}")
+    if average <= 10:


for consistency either make this to elif or the following to if. Or just a blank line in between between the previous if statement and this one.

Add ppk test and update nightly badge accordingly. Also, add html interactive power plot, hosted on github pages. Signed-off-by: Giacomo Dematteis <[email protected]>

DematteisGiacomo requested review from jorgenmk and dilner November 18, 2024 15:21

DematteisGiacomo force-pushed the ppk_test branch from fb57529 to 9b03968 Compare November 18, 2024 15:27

DematteisGiacomo had a problem deploying to production November 18, 2024 15:29 — with GitHub Actions Failure

DematteisGiacomo temporarily deployed to production November 19, 2024 07:55 — with GitHub Actions Inactive

DematteisGiacomo force-pushed the ppk_test branch from 9b03968 to d12fd0f Compare November 19, 2024 08:08

DematteisGiacomo temporarily deployed to production November 19, 2024 08:15 — with GitHub Actions Inactive

jorgenmk reviewed Nov 19, 2024

View reviewed changes

dilner reviewed Nov 19, 2024

View reviewed changes

DematteisGiacomo force-pushed the ppk_test branch 3 times, most recently from ab1171e to 2a0c613 Compare November 19, 2024 11:34

DematteisGiacomo temporarily deployed to production November 19, 2024 11:36 — with GitHub Actions Inactive

DematteisGiacomo force-pushed the ppk_test branch 3 times, most recently from 16f5a62 to c5f23d3 Compare November 19, 2024 11:50

DematteisGiacomo temporarily deployed to production November 19, 2024 11:53 — with GitHub Actions Inactive

DematteisGiacomo force-pushed the ppk_test branch from bc337b8 to 52495f8 Compare November 19, 2024 13:53

DematteisGiacomo had a problem deploying to production November 19, 2024 13:53 — with GitHub Actions Failure

DematteisGiacomo force-pushed the ppk_test branch from 52495f8 to bbf692e Compare November 19, 2024 14:06

DematteisGiacomo temporarily deployed to production November 19, 2024 14:07 — with GitHub Actions Inactive

DematteisGiacomo force-pushed the ppk_test branch from bbf692e to e56a0e5 Compare November 19, 2024 14:21

DematteisGiacomo temporarily deployed to production November 19, 2024 14:21 — with GitHub Actions Inactive

DematteisGiacomo requested review from dilner and jorgenmk November 19, 2024 14:23

DematteisGiacomo temporarily deployed to production November 19, 2024 14:40 — with GitHub Actions Inactive

DematteisGiacomo force-pushed the ppk_test branch from e56a0e5 to ef09879 Compare November 20, 2024 07:56

DematteisGiacomo had a problem deploying to production November 20, 2024 07:58 — with GitHub Actions Failure

DematteisGiacomo force-pushed the ppk_test branch from ef09879 to b9d7233 Compare November 20, 2024 08:03

DematteisGiacomo temporarily deployed to production November 20, 2024 08:48 — with GitHub Actions Inactive

tests: on_target: add ppk test

3fcf785

Add ppk test and update nightly badge accordingly. Also, add html interactive power plot, hosted on github pages. Signed-off-by: Giacomo Dematteis <[email protected]>

DematteisGiacomo force-pushed the ppk_test branch from b9d7233 to 3fcf785 Compare November 20, 2024 09:19

DematteisGiacomo temporarily deployed to production November 20, 2024 09:19 — with GitHub Actions Inactive

jorgenmk approved these changes Nov 20, 2024

View reviewed changes

DematteisGiacomo merged commit 65dd69b into main Nov 20, 2024
2 checks passed

DematteisGiacomo deleted the ppk_test branch November 20, 2024 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: on_target: add ppk test #474

tests: on_target: add ppk test #474

DematteisGiacomo commented Nov 18, 2024

DematteisGiacomo commented Nov 19, 2024 •

edited

Loading

jorgenmk Nov 19, 2024

jorgenmk Nov 19, 2024

jorgenmk Nov 19, 2024

DematteisGiacomo Nov 19, 2024 •

edited

Loading

jorgenmk Nov 19, 2024

jorgenmk Nov 19, 2024

DematteisGiacomo Nov 19, 2024

jorgenmk Nov 19, 2024

DematteisGiacomo Nov 19, 2024

dilner Nov 19, 2024

DematteisGiacomo Nov 19, 2024

dilner Nov 19, 2024

dilner Nov 19, 2024

tests: on_target: add ppk test #474

tests: on_target: add ppk test #474

Conversation

DematteisGiacomo commented Nov 18, 2024

DematteisGiacomo commented Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DematteisGiacomo Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DematteisGiacomo commented Nov 19, 2024 •

edited

Loading

DematteisGiacomo Nov 19, 2024 •

edited

Loading