modules: led: Improve error handling #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensrostad
force-pushed
the
pwmfix
branch
4 times, most recently
from
2c0a073 to
1282c78
Compare
simensrostad
force-pushed
the
pwmfix
branch
3 times, most recently
from
04e46b7 to
f5f45cb
Compare
simensrostad
changed the title
Improve error handling: - Add missing error handling for function calls - Cleanup log statements - Propagate errors to the led module - Make PWM start and stop functions static, remove from API. Not used externally. - Add check that prevents led pwm work to set a pattern if the pwm is suspended via power management. - Remove unneeded kconfig Signed-off-by: Simen S. Røstad <[email protected]>
simensrostad
force-pushed
the
pwmfix
branch
from
f5f45cb to
2f02683
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling:
remove from API. Not used externally.
the pwm is suspended via power management.