Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add menu text style #664

Merged
merged 4 commits into from
Aug 28, 2021
Merged

add menu text style #664

merged 4 commits into from
Aug 28, 2021

Conversation

cossonleo
Copy link
Contributor

add menu text style

@sudormrfbin
Copy link
Member

It should also be added to the book: https://github.com/helix-editor/helix/blob/master/book/src/themes.md.

@cossonleo
Copy link
Contributor Author

It should also be added to the book: https://github.com/helix-editor/helix/blob/master/book/src/themes.md.

Has added

@archseer
Copy link
Member

It should just be ui.menu, that way it matches the convention for other components.

@cossonleo
Copy link
Contributor Author

It should just be ui.menu, that way it matches the convention for other components.

already chanded

@archseer archseer merged commit d6a9c2c into helix-editor:master Aug 28, 2021
@cossonleo cossonleo deleted the menu_text branch August 29, 2021 21:51
@TimonPost TimonPost mentioned this pull request Jul 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cossonleo @sudormrfbin @archseer