Fix lack of space for popup crash #5529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
|
this just crashed my editor losing a bunch of changes i was making, pls merge! |
5 tasks
howard36
reviewed
Feb 12, 2023
|
@nuid32 Seems like there was a misunderstanding, I wasn't suggesting to close this. See my comment above (which is now hidden) |
My fault, haven't enough time to sort out. |
|
Was this supposed to be closed? |
I'm sorry, no, it's not. I just deleted my fork of helix and I totally forgot about this PR. I will fix it right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places None can be returned from one of required_size implementations. I fixed markdown implementation by merely deleting code, that returned None. Did some other minor fixes to prevent crash.
#5448