Dynamically load grammar libraries at runtime #432
Conversation
archseer
force-pushed
the
dynlib-grammars
branch
from
50a6c9f to
2993d9c
Compare
archseer
force-pushed
the
dynlib-grammars
branch
from
2993d9c to
ba5981c
Compare
| }; | ||
| std::mem::forget(library); |
There was a problem hiding this comment.
I'm not sure about simply forgetting the library, maybe we can return a wrapper around Language and Library so their lifetime is tied (and Library is unloaded when the Language is not used anymore).
Just to be sure, is get_language called exactly once for each language?
There was a problem hiding this comment.
I copied this verbatim from tree-sitter (though they admittedly use it more short lived). Or LanguageConfig & HighlightConfig are static, they only get initialized once (wrapped in a OnceCell) then live indefinitely in the registry and are never dropped. So I think for the time being this forget is fine (it implies the grammar lives as &'static)
Windows places temporary files in the current dir, so compiling in parallel caused conflicts.
archseer
force-pushed
the
dynlib-grammars
branch
from
7fa9eea to
605ce98
Compare
archseer
force-pushed
the
dynlib-grammars
branch
from
605ce98 to
3d0f190
Compare
| let mut result = String::with_capacity(name.len()); | ||
| for c in name.chars() { | ||
| if c == '-' { | ||
| result.push('_'); | ||
| } else { | ||
| result.push(c); | ||
| } | ||
| }; | ||
| } | ||
| result |
There was a problem hiding this comment.
Why not just name.replace('-', "_")?
Motivated by some of the findings in #330 I went ahead and attempted to split out grammars.
The set of languages is no longer static, this way the user will be able to self-compile additional grammars and provide them under
runtime/grammars. Languages can now be declared without a matching grammar too, which should unblock #205.I think it would be cool to expose some of the
build.rscode as an optional feature under thehxCLI, so that the user would be able to easily point to a cloned tree sitter grammar and compile it into their runtime dir.Additionally, the grammar objects are now persisted and we only recompile when necessary (if the grammar sources changed), which should massively speed up
cargo clean && cargo build.With these changes, release build of
hxis now7.8Mafter stripping.