Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve C# syntax highlighting #4118

Merged
merged 4 commits into from
Oct 10, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion languages.toml
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ language-server = { command = "OmniSharp", args = [ "--languageserver" ] }

[[grammar]]
name = "c-sharp"
source = { git = "https://github.com/tree-sitter/tree-sitter-c-sharp", rev = "9c494a503c8e2044bfffce57f70b480c01a82f03" }
source = { git = "https://github.com/tree-sitter/tree-sitter-c-sharp", rev = "5b60f99545fea00a33bbfae5be956f684c4c69e2" }

[[language]]
name = "go"
Expand Down
102 changes: 67 additions & 35 deletions runtime/queries/c-sharp/highlights.scm
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
(member_access_expression
name: (identifier) @function))

(invocation_expression
(member_access_expression
expression: ((identifier) @type
(#match? @type "^[A-Z]"))))

(invocation_expression
(member_access_expression
expression: (identifier) @variable))
Expand All @@ -19,12 +24,12 @@
name: (identifier) @function)))

(invocation_expression
[(identifier) (qualified_name)] @function)
[(identifier) (qualified_name)] @function)

; Generic Method invocation with generic type
(invocation_expression
function: (generic_name
. (identifier) @function))
. (identifier) @function))

;; Namespaces

Expand All @@ -40,6 +45,7 @@
(namespace_declaration name: (identifier) @type)
(using_directive (_) @namespace)
(constructor_declaration name: (identifier) @type)
(destructor_declaration name: (identifier) @type)
(object_creation_expression [(identifier) (qualified_name)] @type)
(type_parameter_list (type_parameter) @type)

Expand All @@ -66,15 +72,15 @@

(object_creation_expression
(generic_name
(identifier) @type))
(identifier) @type))

(property_declaration
(generic_name
(identifier) @type))

(_
type: (generic_name
(identifier) @type))
(identifier) @type))

;; Enum
(enum_member_declaration (identifier) @variable.other.member)
Expand Down Expand Up @@ -150,6 +156,7 @@
"%"
"%="
":"
"::"
".."
"&="
"->"
Expand All @@ -166,50 +173,27 @@
] @punctuation.bracket

;; Keywords
(modifier) @keyword
(modifier) @keyword.storage.modifier
(this_expression) @keyword
(escape_sequence) @constant.character.escape

[
"as"
"base"
"break"
"case"
"catch"
"checked"
"class"
"continue"
"default"
"delegate"
"do"
"else"
"enum"
"event"
"explicit"
"finally"
"for"
"foreach"
"goto"
"if"
"implicit"
"interface"
"is"
"lock"
"namespace"
"operator"
"params"
"return"
"sizeof"
"stackalloc"
"static"
"struct"
"switch"
"throw"
"try"
"typeof"
"unchecked"
"using"
"while"
"new"
"await"
"in"
Expand All @@ -222,12 +206,48 @@
"from"
"where"
"select"
"record"
"init"
"with"
"let"
] @keyword

[
"class"
"delegate"
"enum"
"event"
"interface"
"namespace"
"struct"
"record"
] @keyword.storage.type

[
"explicit"
"implicit"
"static"
] @keyword.storage.modifier

[
"for"
"foreach"
"do"
"while"
"break"
"continue"
] @keyword.control.repeat

[
"goto"
"if"
"else"
"switch"
"case"
"default"
] @keyword.control.conditional

"return" @keyword.control.return

(nullable_directive) @keyword.directive
(define_directive) @keyword.directive
(undef_directive) @keyword.directive
Expand Down Expand Up @@ -296,11 +316,11 @@

(parameter_list
(parameter
name: (identifier) @parameter))
name: (identifier) @parameter))

(parameter_list
(parameter
type: [(identifier) (qualified_name)] @type))
type: [(identifier) (qualified_name)] @type))

;; Typeof
(type_of_expression [(identifier) (qualified_name)] @type)
Expand Down Expand Up @@ -334,14 +354,26 @@
(lock_statement (identifier) @variable)

;; Rest
(member_access_expression) @variable
(member_access_expression
expression: ((identifier) @type
(#match? @type "^[A-Z]")))
the-mikedavis marked this conversation as resolved.
Show resolved Hide resolved
(member_access_expression expression: (identifier) @variable)
(member_access_expression name: (identifier) @variable)
(element_access_expression (identifier) @variable)
(argument (identifier) @variable)
(for_statement (identifier) @variable)
(for_each_statement type: (identifier) @type)
(for_each_statement (identifier) @variable)
(expression_statement (identifier) @variable)
(member_access_expression expression: (identifier) @variable)
(member_access_expression name: (identifier) @variable)
(conditional_access_expression [(identifier) (qualified_name)] @variable)
((identifier) @comment.unused
(#eq? @comment.unused "_"))
(#eq? @comment.unused "_"))
(array_type (identifier) @type)
(array_rank_specifier (identifier) @variable)
(equals_value_clause (identifier) @variable)
(interpolation (identifier) @variable)
(interpolation_format_clause) @string
(cast_expression (identifier) @variable)
(declaration_expression name: (identifier) @variable)
(declaration_expression type: (identifier) @type)
(if_statement (identifier) @variable)