The Great Line Ending & Cursor Range Cleanup #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cessen
force-pushed
the
great_line_ending_and_cursor_range_cleanup
branch
2 times, most recently
from
b194d54 to
9493688
Compare
This way they do less work, are more specific to what we actually need, and they compose.
cessen
force-pushed
the
great_line_ending_and_cursor_range_cleanup
branch
from
51d0168 to
e725957
Compare
In particular, this wraps the annoying logic involved in keeping the cursor width to 1 grapheme.
cessen
force-pushed
the
great_line_ending_and_cursor_range_cleanup
branch
from
a1f9ec8 to
b4c59b4
Compare
cessen
force-pushed
the
great_line_ending_and_cursor_range_cleanup
branch
from
774a8e1 to
954314a
Compare
Also tweaked some of the existing behavior that seemed inconsistent and/or buggy. It's mostly identical, just a few corner cases are different.
Rather than per-command like before.
|
This is almost done. There's just one last bug I need to track down, where |
Forgot to convert from char indices to byte indices before passing to the regex engine.
|
Yup, silly mistake on my part. Fixed! I think this is ready for a final round of reviews, now. |
archseer
approved these changes
Jul 29, 2021
|
Great work! |
cessen
added a commit
to cessen/helix
that referenced
this pull request
Aug 3, 2021
pickfire
pushed a commit
that referenced
this pull request
Aug 4, 2021
Closed
Closed
Closed
This was referenced Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #362.
Switch all code over to:
All code has been adjusted so that it still presents an on-char indexing model to the user, but internally everything works in terms of gap indexing.