Restore section spacing in tutor. #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Jun 16, 2022
|
Based on #506 (comment) I think the spacing is probably Omnikar's preference as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of empty lines between sections were truncated to 3 lines in #2590, but they were already deliberately spaced out by @Omnikar such that a section would take up exactly a 80x24 terminal screen (so 22 lines per section if you account for the status line).
Apparently @Omnikar approved of that change change though they didn't make any comment the pr itself. If the decision was made to truncate the spacing intentionally then that's fine, I was just confused why it was done.