LSP Client: Accept floats with trailing zeros as valid JSONRPC IDs #12376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelselleck
force-pushed
the
samsel/jsonrpc-number-fractions
branch
from
72c740c to
976cd72
Compare
`u64::MAX as f64` is actually a number higher than `u64::MAX`:
18,446,744,073,709,552,000 >
18,446,744,073,709,551,615
so it's not an effective gate to reject floats that are too large. We're
unlikely to ever see a float come in that is larger than `u64::MAX` so
we can drop this check for the sake of simplicity.
Also removed a level of nesting and added a comment for context.
the-mikedavis
changed the title
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
akhenakh
pushed a commit
to akhenakh/helix
that referenced
this pull request
Jan 4, 2025
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Jan 6, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #12367
I'm not particularly familiar with serde, but couldn't find a way of only accepting the trailing suffix ".0". Instead of stripping ".0" this tries to parse the id as a
serde_json::Numberand accepts either a u64 or a f64 with zero fractional parts (.0, .00, .000, etc.).