Colors for items in the completion menu #12299

nik-rev · 2024-12-19T15:22:55Z

This PR adds little colored boxes to completion items if its a color

It works on any Color completion item, so it works with CSS, tailwindcss, any other language server which provides "colors".

helix-term/src/ui/completion.rs

TornaxO7

Just my two cents 👀 You can decline them. But nice feature!

helix-term/src/ui/completion.rs

helix-view/src/graphics.rs

helix-term/src/ui/completion.rs

…t be parsed

tveskag · 2024-12-20T01:50:14Z

This looks like it will conflict with #12151. It would be logical to combine the two if possible

nik-rev · 2024-12-20T06:08:09Z

This looks like it will conflict with #12151. It would be logical to combine the two if possible

It's not possible to think about all 272 PRs and whether this one will conflict with any of them

depending on which PR gets merged first, the other has to resolve merge conflicts

nik-rev · 2024-12-20T06:10:36Z

Not for this PR, but a good follow up would be to add the square before any colour string in a file, not just on LSP completions.

I'm actually working on that https://github.com/NikitaRevenco/helix/tree/textDocument/documentColor :)

DaveTJones · 2024-12-20T09:31:15Z

Just a thought, is the word 'color' before every color maybe a little redundant? The only scenario in which I can see this being useful is one in which the color to be rendered happens to match the background.

An alternative use for this space might be to show the hex/RGB/HSL representation of the color?

nik-rev · 2024-12-20T09:42:00Z

Just a thought, is the word 'color' before every color maybe a little redundant? The only scenario in which I can see this being useful is one in which the color to be rendered happens to match the background.

An alternative use for this space might be to show the hex/RGB/HSL representation of the color?

I think it's fine to keep it as is, if we have a bunch of hsl/hex/rgb colors it will get messy + the only information we actually do have is hex colors.

We would have to manually convert them to hsl/rgb if we needed to. Then, which should be pick - rgb or hsl?"Should it be a config option? + You can already see what the color is from the completion menu. It introduces so much unnecessary complexity and not worth it at all imo

DaveTJones · 2024-12-20T19:20:59Z

I think it's fine to keep it as is, if we have a bunch of hsl/hex/rgb colors it will get messy + the only information we actually do have is hex colors.

We would have to manually convert them to hsl/rgb if we needed to. Then, which should be pick - rgb or hsl?"Should it be a config option? + You can already see what the color is from the completion menu. It introduces so much unnecessary complexity and not worth it at all imo

I agree that adding a RGB or HSL option is probably not worth the effort. My main point was that annotating each color as 'color' is redundant.

nik-rev · 2024-12-20T19:49:38Z

I think it's fine to keep it as is, if we have a bunch of hsl/hex/rgb colors it will get messy + the only information we actually do have is hex colors.
We would have to manually convert them to hsl/rgb if we needed to. Then, which should be pick - rgb or hsl?"Should it be a config option? + You can already see what the color is from the completion menu. It introduces so much unnecessary complexity and not worth it at all imo

I agree that adding a RGB or HSL option is probably not worth the effort. My main point was that annotating each color as 'color' is redundant.

it's for accessibility, since not everyone can recognize differences between colors

nferhat · 2024-12-27T09:28:27Z

Nice stuff! Can be easily merged with #12151

atheeq-rhxn · 2025-01-11T17:43:28Z

The colors preview is not working for dart

helix_color_completion_not_working_for_dart.mp4

is it a problem with dart lsp?

nik-rev · 2025-01-11T18:32:24Z

The colors preview is not working for dart
helix_color_completion_not_working_for_dart.mp4

is it a problem with dart lsp?

yes. And there is nothing we can do about it.

The LSP needs to send documentation containing the hex code like #fafafa, which is what all other LSPs which have color completions do

the-mikedavis · 2025-01-11T21:12:28Z

What does the dart language server send for color completions? What does the log say when running in verbose mode (hx -v) when completing a color?

atheeq-rhxn · 2025-01-12T07:39:36Z

What does the dart language server send for color completions? What does the log say when running in verbose mode (hx -v) when completing a color?

They seem to directly give the png of color

The logs:

2025-01-12T13:00:04.015 helix_term::handlers::signature_help [ERROR] signature help request failed: failed to parse: invalid value: integer `-1`, expected u32
2025-01-12T13:00:04.044 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"completionItem/resolve","params":{"detail":"Color","documentation":"Completely opaque black.\n\n![](https://flutter.github.io/assets-for-api-docs/assets/material/Colors.blacks.png)\n\nSee also:\n\n * [black87], [black54], [black45], [black38], [black26], [black12], which\n   are variants on this color but with different opacities.\n * [white], a solid white color.\n * [transparent], a fully-transparent color.\n\n#000000","kind":16,"label":"black","sortText":"9416","textEdit":{"newText":"black","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}},"id":6}
2025-01-12T13:00:04.045 helix_lsp::transport [INFO] dart <- {"id":6,"jsonrpc":"2.0","result":{"detail":"Color","documentation":"Completely opaque black.\n\n![](https://flutter.github.io/assets-for-api-docs/assets/material/Colors.blacks.png)\n\nSee also:\n\n * [black87], [black54], [black45], [black38], [black26], [black12], which\n   are variants on this color but with different opacities.\n * [white], a solid white color.\n * [transparent], a fully-transparent color.\n\n#000000","kind":16,"label":"black","sortText":"9416","textEdit":{"newText":"black","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}}}
2025-01-12T13:00:04.046 helix_lsp::transport [INFO] dart <- {"detail":"Color","documentation":"Completely opaque black.\n\n![](https://flutter.github.io/assets-for-api-docs/assets/material/Colors.blacks.png)\n\nSee also:\n\n * [black87], [black54], [black45], [black38], [black26], [black12], which\n   are variants on this color but with different opacities.\n * [white], a solid white color.\n * [transparent], a fully-transparent color.\n\n#000000","kind":16,"label":"black","sortText":"9416","textEdit":{"newText":"black","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}}
2025-01-12T13:00:04.510 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"textDocument/signatureHelp","params":{"position":{"character":29,"line":8},"textDocument":{"uri":"file:///home/atheeq/Documents/code/dart/x/lib/currency_converter.dart"}},"id":7}
2025-01-12T13:00:04.512 helix_lsp::transport [INFO] dart <- {"id":7,"jsonrpc":"2.0","result":{"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]}}
2025-01-12T13:00:04.512 helix_lsp::transport [INFO] dart <- {"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]}
2025-01-12T13:00:04.512 helix_term::handlers::signature_help [ERROR] signature help request failed: failed to parse: invalid value: integer `-1`, expected u32
2025-01-12T13:00:04.540 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"completionItem/resolve","params":{"detail":"Color","documentation":"Black with 87% opacity.\n\nThis is a good contrasting color for text in light themes.\n\n![](https://flutter.github.io/assets-for-api-docs/assets/material/Colors.blacks.png)\n\nSee also:\n\n * [Typography.black], which uses this color for its text styles.\n * [Theme.of], which allows you to select colors from the current theme\n   rather than hard-coding colors in your build methods.\n * [black], [black54], [black45], [black38], [black26], [black12], which\n   are variants on this color but with different opacities.\n\n#000000","kind":16,"label":"black87","sortText":"9416","textEdit":{"newText":"black87","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}},"id":8}
2025-01-12T13:00:04.542 helix_lsp::transport [INFO] dart <- {"id":8,"jsonrpc":"2.0","result":{"detail":"Color","documentation":"Black with 87% opacity.\n\nThis is a good contrasting color for text in light themes.\n\n![](https://flutter.github.io/assets-for-api-docs/assets/material/Colors.blacks.png)\n\nSee also:\n\n * [Typography.black], which uses this color for its text styles.\n * [Theme.of], which allows you to select colors from the current theme\n   rather than hard-coding colors in your build methods.\n * [black], [black54], [black45], [black38], [black26], [black12], which\n   are variants on this color but with different opacities.\n\n#000000","kind":16,"label":"black87","sortText":"9416","textEdit":{"newText":"black87","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}}}
2025-01-12T13:00:04.542 helix_lsp::transport [INFO] dart <- {"detail":"Color","documentation":"Black with 87% opacity.\n\nThis is a good contrasting color for text in light themes.\n\n![](https://flutter.github.io/assets-for-api-docs/assets/material/Colors.blacks.png)\n\nSee also:\n\n * [Typography.black], which uses this color for its text styles.\n * [Theme.of], which allows you to select colors from the current theme\n   rather than hard-coding colors in your build methods.\n * [black], [black54], [black45], [black38], [black26], [black12], which\n   are variants on this color but with different opacities.\n\n#000000","kind":16,"label":"black87","sortText":"9416","textEdit":{"newText":"black87","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}}
2025-01-12T13:00:05.008 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"textDocument/signatureHelp","params":{"position":{"character":29,"line":8},"textDocument":{"uri":"file:///home/atheeq/Documents/code/dart/x/lib/currency_converter.dart"}},"id":9}
2025-01-12T13:00:05.011 helix_lsp::transport [INFO] dart <- {"id":9,"jsonrpc":"2.0","result":{"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]}}
2025-01-12T13:00:05.011 helix_lsp::transport [INFO] dart <- {"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]}
2025-01-12T13:00:05.011 helix_term::handlers::signature_help [ERROR] signature help request failed: failed to parse: invalid value: integer `-1`, expected u32

nik-rev · 2025-01-12T08:37:35Z

What does the dart language server send for color completions? What does the log say when running in verbose mode (hx -v) when completing a color?

They seem to directly give the png of color

The logs:

2025-01-12T13:00:04.015 helix_term::handlers::signature_help [ERROR] signature help request failed: failed to parse: invalid value: integer -1, expected u32 2025-01-12T13:00:04.044 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"completionItem/resolve","params":{"detail":"Color","documentation":"Completely opaque black.\n\n\n\nSee also:\n\n * [black87], [black54], [black45], [black38], [black26], [black12], which\n are variants on this color but with different opacities.\n * [white], a solid white color.\n * [transparent], a fully-transparent color.\n\n#000000","kind":16,"label":"black","sortText":"9416","textEdit":{"newText":"black","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}},"id":6} 2025-01-12T13:00:04.045 helix_lsp::transport [INFO] dart <- {"id":6,"jsonrpc":"2.0","result":{"detail":"Color","documentation":"Completely opaque black.\n\n\n\nSee also:\n\n * [black87], [black54], [black45], [black38], [black26], [black12], which\n are variants on this color but with different opacities.\n * [white], a solid white color.\n * [transparent], a fully-transparent color.\n\n#000000","kind":16,"label":"black","sortText":"9416","textEdit":{"newText":"black","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}}} 2025-01-12T13:00:04.046 helix_lsp::transport [INFO] dart <- {"detail":"Color","documentation":"Completely opaque black.\n\n\n\nSee also:\n\n * [black87], [black54], [black45], [black38], [black26], [black12], which\n are variants on this color but with different opacities.\n * [white], a solid white color.\n * [transparent], a fully-transparent color.\n\n#000000","kind":16,"label":"black","sortText":"9416","textEdit":{"newText":"black","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}} 2025-01-12T13:00:04.510 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"textDocument/signatureHelp","params":{"position":{"character":29,"line":8},"textDocument":{"uri":"file:///home/atheeq/Documents/code/dart/x/lib/currency_converter.dart"}},"id":7} 2025-01-12T13:00:04.512 helix_lsp::transport [INFO] dart <- {"id":7,"jsonrpc":"2.0","result":{"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]}} 2025-01-12T13:00:04.512 helix_lsp::transport [INFO] dart <- {"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]} 2025-01-12T13:00:04.512 helix_term::handlers::signature_help [ERROR] signature help request failed: failed to parse: invalid value: integer -1, expected u32 2025-01-12T13:00:04.540 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"completionItem/resolve","params":{"detail":"Color","documentation":"Black with 87% opacity.\n\nThis is a good contrasting color for text in light themes.\n\n\n\nSee also:\n\n * [Typography.black], which uses this color for its text styles.\n * [Theme.of], which allows you to select colors from the current theme\n rather than hard-coding colors in your build methods.\n * [black], [black54], [black45], [black38], [black26], [black12], which\n are variants on this color but with different opacities.\n\n#000000","kind":16,"label":"black87","sortText":"9416","textEdit":{"newText":"black87","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}},"id":8} 2025-01-12T13:00:04.542 helix_lsp::transport [INFO] dart <- {"id":8,"jsonrpc":"2.0","result":{"detail":"Color","documentation":"Black with 87% opacity.\n\nThis is a good contrasting color for text in light themes.\n\n\n\nSee also:\n\n * [Typography.black], which uses this color for its text styles.\n * [Theme.of], which allows you to select colors from the current theme\n rather than hard-coding colors in your build methods.\n * [black], [black54], [black45], [black38], [black26], [black12], which\n are variants on this color but with different opacities.\n\n#000000","kind":16,"label":"black87","sortText":"9416","textEdit":{"newText":"black87","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}}} 2025-01-12T13:00:04.542 helix_lsp::transport [INFO] dart <- {"detail":"Color","documentation":"Black with 87% opacity.\n\nThis is a good contrasting color for text in light themes.\n\n\n\nSee also:\n\n * [Typography.black], which uses this color for its text styles.\n * [Theme.of], which allows you to select colors from the current theme\n rather than hard-coding colors in your build methods.\n * [black], [black54], [black45], [black38], [black26], [black12], which\n are variants on this color but with different opacities.\n\n#000000","kind":16,"label":"black87","sortText":"9416","textEdit":{"newText":"black87","range":{"end":{"character":22,"line":8},"start":{"character":22,"line":8}}}} 2025-01-12T13:00:05.008 helix_lsp::transport [INFO] dart -> {"jsonrpc":"2.0","method":"textDocument/signatureHelp","params":{"position":{"character":29,"line":8},"textDocument":{"uri":"file:///home/atheeq/Documents/code/dart/x/lib/currency_converter.dart"}},"id":9} 2025-01-12T13:00:05.011 helix_lsp::transport [INFO] dart <- {"id":9,"jsonrpc":"2.0","result":{"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]}} 2025-01-12T13:00:05.011 helix_lsp::transport [INFO] dart <- {"activeParameter":-1,"activeSignature":0,"signatures":[{"documentation":{"kind":"markdown","value":"Creates the side of a border.\n\nBy default, the border is 1.0 logical pixels wide and solid black."},"label":"BorderSide({Color color = const Color(0xFF000000), double width = 1.0, BorderStyle style = BorderStyle.solid, double strokeAlign = strokeAlignInside})","parameters":[{"label":"Color color = const Color(0xFF000000)"},{"label":"double width = 1.0"},{"label":"BorderStyle style = BorderStyle.solid"},{"label":"double strokeAlign = strokeAlignInside"}]}]} 2025-01-12T13:00:05.011 helix_term::handlers::signature_help [ERROR] signature help request failed: failed to parse: invalid value: integer -1, expected u32

What about colors other than black? From what I can see the documentation for each completion request includes the hex color at the end.

nik-rev · 2025-01-12T08:52:14Z

Could you build this branch and let me know if it works for you? https://github.com/nik-rev/helix/tree/colored-color-completions-fix

atheeq-rhxn · 2025-01-12T09:21:38Z

Could you build this branch and let me know if it works for you? https://github.com/nik-rev/helix/tree/colored-color-completions-fix

Its working!!

Why does building from source brings no theme though?

nferhat · 2025-01-12T09:29:16Z

Why does building from source brings no theme though?

Because it looks for runtime files elsewhere

nik-rev · 2025-01-12T11:50:17Z

Could you build this branch and let me know if it works for you? https://github.com/nik-rev/helix/tree/colored-color-completions-fix

Its working!!

Why does building from source brings no theme though?

Alright, good to know! I've made a pull request for that: #12501

nik-rev changed the title ~~feat: "Color" completion items now have a little box next to them showing the actual color~~ feat: Color completion items now have a little box next to them showing the actual color Dec 19, 2024

nik-rev changed the title ~~feat: Color completion items now have a little box next to them showing the actual color~~ feat: Preview color for completion items Dec 19, 2024

nik-rev changed the title ~~feat: Preview color for completion items~~ Preview color for completion items Dec 19, 2024

nik-rev changed the title ~~Preview color for completion items~~ Color for completion items Dec 19, 2024

nik-rev changed the title ~~Color for completion items~~ Colors in the completion menu for items with CompletionItemKind::COLOR Dec 19, 2024

nik-rev changed the title ~~Colors in the completion menu for items with CompletionItemKind::COLOR~~ Colors for items in the completion menu Dec 19, 2024

the-mikedavis reviewed Dec 19, 2024

View reviewed changes

helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved

helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved

helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved

TornaxO7 reviewed Dec 19, 2024

View reviewed changes

helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved

nik-rev requested a review from the-mikedavis December 19, 2024 17:44

the-mikedavis reviewed Dec 19, 2024

View reviewed changes

helix-view/src/graphics.rs Show resolved Hide resolved

helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved

helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved

nik-rev added 20 commits December 19, 2024 21:26

feat: show color boxes in color completion

a0a622d

feat: larger boxess

2b0c425

refactor: no longer need so many .into()

565c981

refactor: better variable naming

22259e3

perf: do not use unnecessary clone

f1281b1

feat: do not add unnecessary custom method

b7f7e25

refactor: do not use extra dependency

fbbb045

feat: remove dependency

3097c7e

refactor: use an array of ranges

d991979

refactor: extract into a from_hex method on Color

495adf7

refactor: do not return early

73286a1

feat: use "color" text for accessibility next to a small colored cube

1a2b616

refactor: rename variable for consistency

662b6d3

fix: "color" for items with documentation but a hex value which canno…

fc54f2e

…t be parsed

refactor: remove extra variable assignment

aed0f8d

docs: add doc for from_hex

6617f12

docs: use unwrap in example to extract from Option

b00cac3

docs: place in the correct position

0e7b392

refactor: better variable naming

8e17b74

docs: use Color in doc test

1cc2235

refactor: use .into() instead of explicit Spans::raw

98e408f

filipdutescu approved these changes Dec 20, 2024

View reviewed changes

the-mikedavis added 2 commits December 20, 2024 11:08

style - simplify option handling

cebdc59

style - replace use with qualified path

e25fcfc

the-mikedavis approved these changes Dec 20, 2024

View reviewed changes

the-mikedavis merged commit ba6e6dc into helix-editor:master Dec 20, 2024
6 checks passed

nferhat mentioned this pull request Dec 27, 2024

Completion item kinds customization support V2 #12151

Open

CedricMeu pushed a commit to CedricMeu/helix that referenced this pull request Jan 2, 2025

Colors for items in the completion menu (helix-editor#12299)

0eff232

GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025

Colors for items in the completion menu (helix-editor#12299)

ac0d927

diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025

Colors for items in the completion menu (helix-editor#12299)

5c6d1f4

nik-rev mentioned this pull request Jan 12, 2025

fix: unable to detect Color completion item hex code for some LSPs #12501

Merged

nik-rev deleted the colored-color-completions branch January 12, 2025 11:53

rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025

Colors for items in the completion menu (helix-editor#12299)

611fe8b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Colors for items in the completion menu #12299

Colors for items in the completion menu #12299

nik-rev commented Dec 19, 2024 •

edited

Loading

TornaxO7 left a comment

tveskag commented Dec 20, 2024

nik-rev commented Dec 20, 2024 •

edited

Loading

nik-rev commented Dec 20, 2024 •

edited

Loading

DaveTJones commented Dec 20, 2024

nik-rev commented Dec 20, 2024 •

edited

Loading

DaveTJones commented Dec 20, 2024

nik-rev commented Dec 20, 2024

nferhat commented Dec 27, 2024

atheeq-rhxn commented Jan 11, 2025

nik-rev commented Jan 11, 2025 •

edited

Loading

the-mikedavis commented Jan 11, 2025

atheeq-rhxn commented Jan 12, 2025 •

edited by the-mikedavis

Loading

nik-rev commented Jan 12, 2025

nik-rev commented Jan 12, 2025

atheeq-rhxn commented Jan 12, 2025 •

edited

Loading

nferhat commented Jan 12, 2025

nik-rev commented Jan 12, 2025

Colors for items in the completion menu #12299

Colors for items in the completion menu #12299

Conversation

nik-rev commented Dec 19, 2024 • edited Loading

TornaxO7 left a comment

Choose a reason for hiding this comment

tveskag commented Dec 20, 2024

nik-rev commented Dec 20, 2024 • edited Loading

nik-rev commented Dec 20, 2024 • edited Loading

DaveTJones commented Dec 20, 2024

nik-rev commented Dec 20, 2024 • edited Loading

DaveTJones commented Dec 20, 2024

nik-rev commented Dec 20, 2024

nferhat commented Dec 27, 2024

atheeq-rhxn commented Jan 11, 2025

nik-rev commented Jan 11, 2025 • edited Loading

the-mikedavis commented Jan 11, 2025

atheeq-rhxn commented Jan 12, 2025 • edited by the-mikedavis Loading

nik-rev commented Jan 12, 2025

nik-rev commented Jan 12, 2025

atheeq-rhxn commented Jan 12, 2025 • edited Loading

nferhat commented Jan 12, 2025

nik-rev commented Jan 12, 2025

nik-rev commented Dec 19, 2024 •

edited

Loading

nik-rev commented Dec 20, 2024 •

edited

Loading

nik-rev commented Dec 20, 2024 •

edited

Loading

nik-rev commented Dec 20, 2024 •

edited

Loading

nik-rev commented Jan 11, 2025 •

edited

Loading

atheeq-rhxn commented Jan 12, 2025 •

edited by the-mikedavis

Loading

atheeq-rhxn commented Jan 12, 2025 •

edited

Loading