fix: report correct amount of files opened and improved error message when Helix can't parse directory as file #12199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-rev
changed the title
pascalkuthe
reviewed
Dec 7, 2024
pascalkuthe
approved these changes
Dec 7, 2024
TornaxO7
approved these changes
Dec 8, 2024
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
… when Helix can't parse directory as file (helix-editor#12199) * feat: improve information on the amount of files loaded * refactor: naming consitency Doc and not Buf * fix: correct name of method * chore: appease clippy * feat: more human error information when Helix cannot start * refatcor: use if guard on match arm
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
… when Helix can't parse directory as file (helix-editor#12199) * feat: improve information on the amount of files loaded * refactor: naming consitency Doc and not Buf * fix: correct name of method * chore: appease clippy * feat: more human error information when Helix cannot start * refatcor: use if guard on match arm
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
… when Helix can't parse directory as file (helix-editor#12199) * feat: improve information on the amount of files loaded * refactor: naming consitency Doc and not Buf * fix: correct name of method * chore: appease clippy * feat: more human error information when Helix cannot start * refatcor: use if guard on match arm
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
… when Helix can't parse directory as file (helix-editor#12199) * feat: improve information on the amount of files loaded * refactor: naming consitency Doc and not Buf * fix: correct name of method * chore: appease clippy * feat: more human error information when Helix cannot start * refatcor: use if guard on match arm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you open two of the same file with
hx README:6 README:8, it will sayOpened 2 fileseven though only 1 file will be opened (with 1 buffer). This PR fixes that, it will sayOpened 1 filenow.The PR also provides context when Helix can't parse a directory as a file. For example, if you do
hx README.md helix-termhelix will think thathelix-termis a file, and since it's a directory you will see an error message:With this PR the error message is improved now:
This could happen accidentally, for example if I run
hx *I might intuitively think that it'll open each file, but it also opens directories(note: I also changed
unable to create new applicationas I don't think it makes sense for someone who has no idea of Helix's internals)