Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WORKSPACE.bzlmod to starlark file-types #12103

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

rcorre
Copy link
Contributor

@rcorre rcorre commented Nov 21, 2024

@the-mikedavis
Copy link
Member

I'm not sure from the Bazel docs whether bzlmod is the only correct suffix? In that case I think we should match on { glob = "WORKSPACE.bzlmod" } specifically

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Nov 22, 2024
@rcorre
Copy link
Contributor Author

rcorre commented Nov 22, 2024

Fixed. WORKSPACE.bazel is also valid but is captured by the existing extension patterns.

@the-mikedavis the-mikedavis changed the title Add WORKSPACE.* to starlark file-types. Add WORKSPACE.bzlmod to starlark file-types Nov 22, 2024
@the-mikedavis the-mikedavis merged commit 46ffec3 into helix-editor:master Nov 22, 2024
6 checks passed
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants