Tombstone LSP clients stopped with :lsp-stop
#11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Servers stopped with `:lsp-stop` will show this message when the server exits. If the client isn't in the registry there isn't any work to do to remove it so this branch is benign.
the-mikedavis
changed the title
:lsp-stop:lsp-stop
pascalkuthe
reviewed
Jul 25, 2024
We use the empty vec in `inner_by_name` as a tombstone value. When the vec is empty `get` should not automatically restart the server.
the-mikedavis
force-pushed
the
lsp-registry-tombstone
branch
from
79ed9e3 to
48efdd4
Compare
pascalkuthe
approved these changes
Jul 25, 2024
archseer
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you stop language server(s) for a file with
:lsp-stopand then open another file from that language, the language server(s) will be restarted. Instead of removing the language server info entirely when we:lsp-stop, we can replace the records in the registry with a "tombstone" which prevents automatic restarts byRegistry::get.Closes #11319