Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling issues in TypeScript LSP hover docs : black background to text #1948

Closed
David-Else opened this issue Apr 3, 2022 · 8 comments · Fixed by #1950
Closed

Styling issues in TypeScript LSP hover docs : black background to text #1948

David-Else opened this issue Apr 3, 2022 · 8 comments · Fixed by #1950
Labels
A-theme Area: Theme and appearence related C-bug Category: This is a bug

Comments

@David-Else
Copy link
Contributor

Summary

With the TypeScript language server there is an unwanted background of black on all the text in the hover. The dialogue box is grey, but each character of the text is in a black box:

Screenshot from 2022-04-03 20-09-15

Reproduction Steps

Just look at any typescript docs with space k

Helix log

~/.cache/helix/helix.log 
please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

linux

Terminal Emulator

kitty

Helix Version

helix 22.03 (d4e45fd)
@David-Else David-Else added the C-bug Category: This is a bug label Apr 3, 2022
@kirawi
Copy link
Member

kirawi commented Apr 3, 2022

I'm guessing it's this line right here that's causing it:

helix/runtime/themes/dark_plus.toml

Line 77 in 9782204

"ui.text" = { fg = "text", bg = "background" }

Could you try deleting bg = "background"? It's been a while, so I don't remember why I originally wrote that.

@kirawi kirawi added the A-theme Area: Theme and appearence related label Apr 3, 2022
@David-Else
Copy link
Contributor Author

@kirawi Great to hear from the theme creator, deleting bg = "background" works!

I have been comparing your theme to VS Code online https://vscode.dev/github/microsoft/vscode and Neovim https://github.com/Mofiqul/vscode.nvim, and it is good! :)

I have found a problem that Markdown looks bad, loads of weird colors that are not part of the theme. Can this be fixed in the theme now? I think the Markdown treesitter parser https://github.com/MDeiml/tree-sitter-markdown/commits/main is semi-new in helix? I only found out about Helix yesterday, can't believe how good it is.

@kirawi
Copy link
Member

kirawi commented Apr 3, 2022 •
edited
Loading

Yeah I didn't get around to adding the markdown colors, so I think the current ones are the ones used by the default theme. I'll try to see if I can do that sometime soon.

@kirawi kirawi closed this as completed Apr 3, 2022
@kirawi kirawi reopened this Apr 3, 2022
kirawi added a commit to kirawi/helix that referenced this issue Apr 3, 2022
@kirawi
[dark_plus] remove ui.text background
9a2793d 
resolves helix-editor#1948
@kirawi kirawi mentioned this issue Apr 3, 2022
Merged
@kirawi
Copy link
Member

kirawi commented Apr 7, 2022

I updated the colors in #1989

@David-Else
Copy link
Contributor Author

@kirawi Afraid there is a bug. I can't select a code action, there is no highlight to see what I am doing. In other themes there is a highlight.

Screenshot from 2022-04-07 15-39-39

@kirawi
Copy link
Member

kirawi commented Apr 7, 2022

I'll look into that too.

@David-Else
Copy link
Contributor Author

@kirawi Also the HTML highlighting seems wrong:

helix

Screenshot from 2022-04-07 20-25-56

neovim using treesitter https://github.com/Mofiqul/vscode.nvim

Screenshot from 2022-04-07 20-26-26

vs code online https://vscode.dev/github/microsoft/vscode

Screenshot from 2022-04-07 20-29-45

<!DOCTYPE html>
<html lang="en">
  <head>
    <title>Img Align Attribute</title>
  </head>
  <body>
    <p>
      This is an example. <img src="image.png" alt="Image" align="middle" /> More text right here
      <img src="image.png" alt="Image" width="100" />
    </p>
  </body>
</html>

@kirawi
Copy link
Member

kirawi commented Apr 8, 2022

Both will be fixed in #2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dark_plus] remove ui.text background kirawi/helix
2 participants
@David-Else @kirawi