Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graphql responseHook support #2

Merged
merged 1 commit into from
May 31, 2021
Merged

feat: graphql responseHook support #2

merged 1 commit into from
May 31, 2021

Conversation

nozik
Copy link
Member

@nozik nozik commented May 6, 2021

Which problem is this PR solving?

  • Add the ability to collect the response to a graphql query (as an optional configuration). This data can be used for monitoring purposes.

Short description of the changes

  • add responseHook config to the GraphQLInstrumentationConfig
  • When provided, safely use it to collect the data from the execution result.

@nozik nozik changed the title Graphql responsehook support feat: graphql responseHook support May 6, 2021
@nozik nozik requested a review from lior-govrin May 6, 2021 06:25
@nozik nozik force-pushed the graphql_responsehook_support branch from ce54b09 to 1a7cd10 Compare May 6, 2021 14:06
@nozik nozik force-pushed the graphql_responsehook_support branch from 1a7cd10 to adcc0a5 Compare May 24, 2021 06:29
@nozik nozik merged commit a075a07 into main May 31, 2021
@nozik nozik deleted the graphql_responsehook_support branch May 31, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lior-govrin lior-govrin lior-govrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nozik @lior-govrin