Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Upgrade Netty to 4.1.90.Final and use Netty BOM for version management #6532

Merged
merged 3 commits into from
Mar 31, 2023
Merged

2.x: Upgrade Netty to 4.1.90.Final and use Netty BOM for version management #6532

merged 3 commits into from
Mar 31, 2023

Conversation

barchetta
Copy link
Member

No description provided.

@barchetta barchetta added 2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file labels Mar 30, 2023
@barchetta barchetta requested a review from ljnelson March 30, 2023 18:23
@barchetta barchetta self-assigned this Mar 30, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 30, 2023
ljnelson
ljnelson previously approved these changes Mar 30, 2023
View reviewed changes
@ljnelson
Copy link
Member

The pipeline beat me to it: I realized you didn't update the copyright in module-info.java.

ljnelson
ljnelson previously approved these changes Mar 30, 2023
View reviewed changes
ljnelson
ljnelson approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; we'll see what the pipelines have to say.

@barchetta barchetta merged commit e58f224 into helidon-io:helidon-2.x Mar 31, 2023
@barchetta barchetta deleted the 2.x-netty-4.1.90.Final branch May 31, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljnelson ljnelson ljnelson approved these changes

Assignees

@barchetta barchetta

Labels
2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @ljnelson