-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCORE Artificat class potential blockage #138
Comments
I agree that there are benefits to this and don’t see any major cons. The only thing to note is that some of the SCORE artifacts are specific to ephys data, and MRI data have different artifacts (eg ringing, Eddy etc), so we should consider that in the hierarchy. |
I think we should just add the high levels as listed above and have SCORE anchor to those. That way different modalities can put own and not conflict with or have to include SCORE... However maybe we only want to put |
Per discussion with @monique2208 the non-biological-artifact category is an exclusive category that does not make sense from an ontological perspective. We have 2 options:
We agreed that 1) would be the best for now. |
Addressed in PR #140 |
It seem like this issue had been resolved and can be closed? |
This is now being handled in issue #144 |
I propose that since going forward SCORE will always be partnered, that in SCORE 2.0.0 we move the hierarchy
Artifact
to the standard schema as:Data-property/Data-artifact-type
and move the major categories of artifact to the standard schema:
Data-property/Data-artifact-type/Biological-artifact
Data-property/Data-artifact-type/Non-biological-artifact
Data-property/Data-artifact-type/Other-artifact
We may want to move a few of the other items that currently appear under that to the standard schema as well. We have an opportunity to do this now with the upcoming release of a major backwards incompatible version of SCORE.
Reasoning: If they stay in SCORE, then anyone who wants to add an artifact type to SCORE will have to add it to SCORE rather than to its own library. If at least the top-level stuff is moved --- SCORE can anchor its specific artifacts in the standard schema but other libraries can add their own artifacts independently. I think this will be a very relevant issue for the upcoming development of a MOBI schema.
@dorahermes @smakeig @neuromechanist @christinerogers @monique2208
The text was updated successfully, but these errors were encountered: