Add email validation scoping #5136
Conversation
For multi tenancy the email validation scoping is crucial. This enhancement is actually based on the currently open PR: heartcombo#5094 As soon as the feature is merged, one should use the Devise trunk again.
|
Hello, @christianrolle! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| @@ -115,6 +115,10 @@ module Test | |||
| mattr_accessor :email_regexp | |||
| @@email_regexp = /\A[^@\s]+@[^@\s]+\z/ | |||
|
|
|||
| # Option to scope the email uniqueness validator | |||
| mattr_accessor :email_scope | |||
| @@email_scope = nil | |||
There was a problem hiding this comment.
Replace class var @@email_scope with a class instance var.
| @@ -115,6 +115,10 @@ module Test | |||
| mattr_accessor :email_regexp | |||
| @@email_regexp = /\A[^@\s]+@[^@\s]+\z/ | |||
|
|
|||
| # Option to scope the email uniqueness validator | |||
| mattr_accessor :email_scope | |||
| @@email_scope = nil | |||
There was a problem hiding this comment.
Devise declares the class variable '@@email_scope'
|
SourceLevel has finished reviewing this Pull Request and has found:
You can see more details about this review at https://app.sourcelevel.io/github/plataformatec/devise/pulls/5136. |
|
Isn't this a duplication of #5094? |
For multi tenancy the email validation scoping is
crucial. This enhancement is actually based on the
currently open PR:
#5094
As soon as the feature is merged, one should use the
Devise trunk again.