Passing :scope option to uniqueness validator of :email #4793
Conversation
Indexes for tokens should have WHERE ...token IS NOT NULL construction.
Else we are admitted to create only one user.
Unfortunatelly, in worse cases people just remove these indexes...
Initially faced with it on MS SQL server (not checked other adapters
though).
Inspired by rails-sqlserver/activerecord-sqlserver-adapter#153
Probably need to add test case for generated migrations with tokens
| add_index :<%= table_name %>, :reset_password_token, unique: true | ||
| # add_index :<%= table_name %>, :confirmation_token, unique: true | ||
| # add_index :<%= table_name %>, :unlock_token, unique: true | ||
| add_index :<%= table_name %>, :reset_password_token, unique: true, where: '([reset_password_token] IS NOT NULL)' |
There was a problem hiding this comment.
Looks like these changes are from #4794, right?
I think we can remove them.
|
@one-more-alex Can you add some tests for this feature? |
|
I can add some tests, but I can't do t at near time. Maybe at weekend... validates_uniqueness_of :email, {allow_blank: true, if: :will_save_change_to_email?}.merge(other_options_scope_case_etc)
To be able add arbitrary options for validator. |
|
No problem, you can do when you're able to. I think your suggestion is a good idea, but since we already have the |
|
@one-more-alex Just to be sure, are you still going to work on this or can I assign it to someone else? |
|
@tegon Sorry for delay. Sure. I do not mind to assign to someone else. |
|
@one-more-alex No problem, I just wanted to know if you still wanted to work on this.
If you need help, let me know. You can add a WIP commit here with your progress so far so I can help, or send your questions.
You mean how to remove the commit from #4794? |
|
I'm closing this pull request because it had no recent activity. Thank you! |
Uniqueness validator of :email must have :scope option setting to solve many difficulties like for: