maintain the FITS dtype in read_map #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read_map forces input to a specific dtype, by default double. Now if dtype is None, it maintains the original dtype.
DanielLenz
suggested changes
May 22, 2019
There was a problem hiding this comment.
Thanks for working on this @zonca , I just had two minor comments.
| @@ -397,15 +398,21 @@ def read_map( | |||
|
|
|||
| for ff, curr_dtype in zip(field, dtype): | |||
| try: | |||
There was a problem hiding this comment.
Is the try/except statement statement still necessary? Perhaps we can simply call hdu.verify("fix"), and then proceed to read?
On a related note, it would also be good to gradually move away from print statements and use the logging module or (even better suited for users) warnings.warn().
There was a problem hiding this comment.
I prefer to use the try/except, not sure how expensive is the verification step.
yes, definitely that would be great to remove all the prints, probably warnings is enough for our purposes
zonca
force-pushed
the
maintain_dtype_read_map
branch
from
cd7dc11 to
3c368a0
Compare
|
Thanks, feel free to merge after travis has run! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_map forces input to a specific dtype, by default double.
Now if dtype is None, it maintains the original dtype.