-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP zarr backend #98
WIP zarr backend #98
Conversation
@kangDH thanks for getting this going! A bunch of us are really excited about incorporating alternative backends! |
@kangDH it looks like you developed this in python 2. Could you change to python 2/3 syntax? e.g. changing |
I'm working on the fixes for Python 3 |
…le name in zarr_tools
@kangDH the following PR donghekang#1 to your branch should fix the test failures for Python 2/3 and flake8. Can you please review and merge the PR with your branch. |
Fix/zarriopy3
Add support for writing the namespace schema
…eferences from attributes. Fix write of object reference attributes
@oruebel Since Zarr only supports chunked datasets, how does this backend handles writing unchunked datasets? Does it write the dataset as one big chunk? |
In that case the |
That could be a problem for large datasets because a user would not be able to read a section of it without reading the entire dataset into memory |
The default option for chunking is set to True currently in ZarrIO. We can run some test with some NWB files. The convert should be fairly simple:
|
…t tests for CSRMatrix
… and remove dependency on h5py
Closing in favor of the new PR #696 |
Motivation
Add support for Zarr DirectoryStore I/O
How to test the behavior?
See the included tests
ToDo
Dependencies
src/hdmf/utils.py
,src/hdmf/io/__init__.py
,tests/unit/test_io_zarr.py
etc.get_docval_macro
function. We should remove the__get_docval_macro
that has been added in this PR and update the code to use the new one from HDMF.Features
exhaust_dci
flag has been moved to the HDF5 backend and removed from HDMFIO)Testing and Documentation
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.