Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy release workflow #845

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Fix deploy release workflow #845

merged 2 commits into from
Apr 7, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 7, 2023

Motivation

The deploy release workflow failed because I forgot to update it when I increased the max python version to 3.11.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel April 7, 2023 07:51
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b07aca7) 87.79% compared to head (8792fe8) 87.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #845   +/-   ##
=======================================
  Coverage   87.79%   87.79%           
=======================================
  Files          44       44           
  Lines        8950     8950           
  Branches     2695     2695           
=======================================
  Hits         7858     7858           
  Misses        779      779           
  Partials      313      313           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rly rly merged commit 5a1bc73 into dev Apr 7, 2023
@rly rly deleted the rly-patch-1 branch April 7, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants