Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #817 Check that __open_links exists before trying to close links #818

Merged
merged 12 commits into from
Jan 24, 2023

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 19, 2023

Motivation

Fix #817

How to test the behavior?

This should fix the issue but I'm not sure yet how to test it.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 87.77% // Head: 87.80% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (8c958e8) compared to base (4d3f724).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #818      +/-   ##
==========================================
+ Coverage   87.77%   87.80%   +0.02%     
==========================================
  Files          44       44              
  Lines        8936     8943       +7     
  Branches     2061     2061              
==========================================
+ Hits         7844     7852       +8     
  Misses        777      777              
+ Partials      315      314       -1     
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5tools.py 82.43% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rly rly changed the title Fix #817 Check that __open_links exists before trying to clsoe links Fix #817 Check that __open_links exists before trying to close links Jan 19, 2023
@rly
Copy link
Contributor

rly commented Jan 19, 2023

Looks good to me. Please fix flake8 and update the changelog for a bugfix release set for tomorrow or Friday.

@oruebel
Copy link
Contributor Author

oruebel commented Jan 19, 2023

Please fix flake8 and update the changelog

I updated the changelog.

Re flake8, it looks like the GitHub workflows are flaky. Several failed with errors along the lines of:

Screen Shot 2023-01-19 at 12 34 15 PM

@oruebel
Copy link
Contributor Author

oruebel commented Jan 24, 2023

@rly I removed the warnings as you suggested in #817 (comment) This PR is ready for review

rly
rly previously approved these changes Jan 24, 2023
@oruebel oruebel merged commit 4da43df into dev Jan 24, 2023
@oruebel oruebel deleted the fix/attr_error_on_del branch January 24, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: 'NWBHDF5IO' object has no attribute '_HDF5IO__open_links'
2 participants