-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #817 Check that __open_links exists before trying to close links #818
Conversation
Codecov ReportBase: 87.77% // Head: 87.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #818 +/- ##
==========================================
+ Coverage 87.77% 87.80% +0.02%
==========================================
Files 44 44
Lines 8936 8943 +7
Branches 2061 2061
==========================================
+ Hits 7844 7852 +8
Misses 777 777
+ Partials 315 314 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looks good to me. Please fix flake8 and update the changelog for a bugfix release set for tomorrow or Friday. |
@rly I removed the warnings as you suggested in #817 (comment) This PR is ready for review |
Motivation
Fix #817
How to test the behavior?
This should fix the issue but I'm not sure yet how to test it.
Checklist
flake8
from the source directory.