Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some mostly redundant CI from on push to nightly #497

Merged
merged 6 commits into from
Dec 8, 2020
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 8, 2020

Motivation

Our CI involves too many jobs -- it takes a long time for all the jobs to complete, especially when trying to merge successive PRs. Some of these jobs can be moved to a nightly build rather than an on-every-push build.

With this PR, CI will consist of:
CircleCI:

  • flake8
  • python38 (3.8 with pip install pinned requirements)
  • python36-min-req (3.6 with pip install minimal requirements)
  • miniconda38 (3.8 on conda with pinned requirements)
  • miniconda36 (3.6 on conda with pinned requirements)
  • gallery38 (gallery/example tests...)
  • gallery36-min-req
  • pynwb-dev-python38 (git pull dev branch of pynwb and run tests)

Azure Pipelines:

  • macOS-py3.8
  • Windows-py3.8
  • macOS-py3.6-min-req
  • Windows-py3.6-min-req

I changed the required CI for a PR merge to be just:

  • circleci/flake8
  • circleci/python36-min-req
  • circleci/python38
  • azure/windows-py3.8

The 'deploy-release' job that creates the pre-releases will move from every time a commit is made to dev to a nightly build.

Nightly build includes testing on every configuration including Python 3.9.

This will cut on-push CI down to 12 jobs + 3 for code coverage, down from 25 + 3 and reduce the CI time on a commit to dev.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from a team December 8, 2020 20:46
@rly rly merged commit 4676ea6 into dev Dec 8, 2020
@rly rly deleted the ci/streamline branch December 8, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants