Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH action for codecov #493

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Fix GH action for codecov #493

merged 2 commits into from
Dec 8, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 8, 2020

Motivation

coverage is not being run correctly in the GitHub Actions because I used python setup.py install instead of python setup.py develop. The former does not provide access to .coveragerc.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from a team December 8, 2020 08:46
@rly rly merged commit 7db29b5 into dev Dec 8, 2020
@rly rly deleted the fix/gh_codecov branch December 8, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants