Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSRMatrix and push coverage to 100%, add to_uint_array util #485

Merged
merged 12 commits into from
Dec 4, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 2, 2020

Motivation

With the change in hdmf-common-schema of dtypes in CSRMatrix from int to uint (hdmf-dev/hdmf-common-schema#46), the API needs to be updated in order to avoid data type conversion warnings.

Also add testing of the different error and edge cases of CSRMatrix.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from ajtritt December 2, 2020 19:50
ajtritt
ajtritt previously approved these changes Dec 2, 2020
@rly rly requested a review from ajtritt December 2, 2020 20:15
oruebel
oruebel previously approved these changes Dec 4, 2020
@rly rly merged commit 1d8a7ac into dev Dec 4, 2020
@rly rly deleted the enh/csr_matrix_update branch December 4, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants