Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing GroupSpec/DatasetSpec for LinkSpec target_type #468

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 17, 2020

Motivation

Fix #464, add missing tests for LinkSpec.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter
Copy link
Contributor

looks great, @rly!

@rly rly requested review from ajtritt and bendichter November 17, 2020 21:42
@rly rly merged commit fab5660 into dev Nov 19, 2020
@rly rly deleted the enh/linkspec branch November 19, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target_type in Spec constructors should take GroupSpec and DatasetSpec
2 participants