Improve ObjectMapper and fix related issues #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ObjectMapper.convert_dt_name(...)
now uses the name of the LinkSpec target type to generate the attribute name instead of throwing an error.ObjectMapper
that caused some objects to be built multiple times.NamespaceCatalog.is_sub_data_type(...)
to accept only strings and refactor.ContainerConfigurationError
if a container class has no attribute mapped to a spec.MissingRequiredBuildWarning
forMissingRequiredWarning
. Use the new warning throughout.BuildManager.is_sub_data_type
method to support checking whether a given AbstractContainer is a sub-data_type of the data type defined by a Spec.GroupSpec.set_link(...)
ObjectMapper.get_builder_name(...)
ObjectMapper
warn for incorrect quantity and missing cases for required groups. Related to Validator should check for quantity #197hdmf.testing.assertBuilderEqual(...)
which compares builder namesChecklist
flake8
from the source directory.