Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow table columns and add_column to specify column class #436

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 6, 2020

Motivation

Address #435

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #436 into dev will increase coverage by 0.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #436      +/-   ##
==========================================
+ Coverage   80.09%   80.10%   +0.01%     
==========================================
  Files          34       34              
  Lines        7233     7237       +4     
  Branches     1584     1585       +1     
==========================================
+ Hits         5793     5797       +4     
  Misses       1059     1059              
  Partials      381      381              
Impacted Files Coverage Δ
src/hdmf/common/table.py 83.58% <84.61%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5a977...31d01a9. Read the comment docs.

@rly rly changed the title Enh/column class Allow table columns and add_column to specify column class Oct 6, 2020
@rly rly requested a review from a team October 6, 2020 23:01
@rly
Copy link
Contributor Author

rly commented Oct 6, 2020

This is necessary for https://github.com/rly/ndx-genotype

oruebel
oruebel previously approved these changes Oct 7, 2020
@rly rly merged commit 023353d into dev Oct 8, 2020
@rly rly deleted the enh/column_class branch October 8, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants