Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default value of None with enum docval #409

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 22, 2020

Motivation

Fix #408

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from a team July 22, 2020 17:20
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #409 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #409   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files          33       33           
  Lines        6921     6921           
  Branches     1518     1518           
=======================================
  Hits         5476     5476           
  Misses       1058     1058           
  Partials      387      387           
Impacted Files Coverage Δ
src/hdmf/utils.py 96.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 574df03...4582d4c. Read the comment docs.

@rly rly merged commit 88fd6dc into dev Jul 22, 2020
@rly rly deleted the fix/docval_enum_none branch July 22, 2020 18:03
@rly rly restored the fix/docval_enum_none branch July 22, 2020 18:03
@rly rly deleted the fix/docval_enum_none branch July 22, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docval with string enum should allow default value of None
2 participants