Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for columns with H5DataIO data #402

Merged
merged 2 commits into from
Jul 18, 2020
Merged

Add tests for columns with H5DataIO data #402

merged 2 commits into from
Jul 18, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 18, 2020

Motivation

HDMF 2.0 added the ability to create table columns with chunks, compression, and other HDF5 IO filters. This PR adds roundtrip tests for this functionality.

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from a team July 18, 2020 00:57
@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #402 into dev will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #402      +/-   ##
==========================================
+ Coverage   78.93%   79.11%   +0.17%     
==========================================
  Files          33       33              
  Lines        6922     6922              
  Branches     1518     1518              
==========================================
+ Hits         5464     5476      +12     
+ Misses       1067     1059       -8     
+ Partials      391      387       -4     
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5tools.py 78.57% <0.00%> (+0.23%) ⬆️
src/hdmf/data_utils.py 89.72% <0.00%> (+0.34%) ⬆️
src/hdmf/common/table.py 83.39% <0.00%> (+0.34%) ⬆️
src/hdmf/validate/validator.py 73.74% <0.00%> (+0.55%) ⬆️
src/hdmf/build/objectmapper.py 80.73% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c258390...63919db. Read the comment docs.

@rly rly merged commit 7c30cc5 into dev Jul 18, 2020
@rly rly deleted the enh/test_chunked_cols branch July 18, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants