Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new flake8 errors #351

Closed
wants to merge 2 commits into from
Closed

Fix new flake8 errors #351

wants to merge 2 commits into from

Conversation

rly
Copy link
Contributor

@rly rly commented May 15, 2020

Fix #350

@rly rly requested a review from a team May 15, 2020 00:28
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #351 into dev will not change coverage.
The diff coverage is 61.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #351   +/-   ##
=======================================
  Coverage   73.51%   73.51%           
=======================================
  Files          33       33           
  Lines        6535     6535           
  Branches     1424     1424           
=======================================
  Hits         4804     4804           
  Misses       1306     1306           
  Partials      425      425           
Impacted Files Coverage Δ
src/hdmf/common/table.py 69.50% <0.00%> (ø)
src/hdmf/backends/hdf5/h5tools.py 66.49% <50.00%> (ø)
src/hdmf/container.py 72.75% <60.00%> (ø)
src/hdmf/build/builders.py 86.68% <66.66%> (ø)
src/hdmf/backends/hdf5/h5_utils.py 66.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2b005...64b0f2a. Read the comment docs.

@ajtritt
Copy link
Contributor

ajtritt commented May 15, 2020

@rly I addressed these in #346. Closing to avoid merge conflicts

@ajtritt ajtritt closed this May 15, 2020
@rly rly deleted the fix/flake8 branch May 15, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake8 errors
2 participants